Repository navigation
Conversation
|
GNU diffutils testsuite comparison: |
sylvestre
reviewed
Oct 18, 2026
| diff = "0.1.13" | ||
| itoa = "1.0.11" | ||
| regex = "1.10.4" | ||
| rustix = { version = "1.1.4", features = ["fs"] } |
Collaborator
There was a problem hiding this comment.
do we really need a new dependency to save one stat() call?
please justify it, or use std (as_fd().try_clone_to_owned() + MetadataExt::rdev())
Contributor
Author
There was a problem hiding this comment.
try_clone needs additional fcntl call.
sylvestre
reviewed
Oct 18, 2026
sylvestre
reviewed
Oct 18, 2026
sylvestre
reviewed
Oct 18, 2026
sylvestre
reviewed
Oct 18, 2026
|
|
||
| #[cfg(any(target_os = "linux", target_os = "android"))] | ||
| fn is_stdout_dev_null() -> bool { | ||
| // as_fd().try_clone_to_owned() needs additional overhead of fcntl |
Collaborator
There was a problem hiding this comment.
the unix version below doesn't need fcntl either (from_raw_fd + forget)
could you please do the same with MetadataExt::rdev() + FileTypeExt::is_char_device() and drop rustix?
Contributor
Author
There was a problem hiding this comment.
Is needs unsafe. Is it OK? clap-rs already pulls rustix.
Contributor
Author
There was a problem hiding this comment.
I think std does not have a feature to check major/minor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't reopen 2nd
/dev/nullatfn is_stdout_dev_nullon Linux.